kola/test/locksmith: update the cert generation #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With OpenSSLv3, there is a tiny regression in the cert generation. The issuer entry is modified _after_ the check for self-signed certificate. So it fails with: ``` subject=CN = localhost Error with certificate - error 20 at depth 0 unable to get local issuer certificate subject=CN = localhost Error with certificate - error 21 at depth 0 unable to verify the first certificate Error with certificate to be certified - should be self-signed ``` workaround is to use intermediate CSR and generate after the cert based on this CSR and by providing the associated extension in order to not lost the SANs. Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
jepio
approved these changes
Oct 4, 2021
Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
tormath1
force-pushed
the
tormath1/opensslv3-workaround
branch
from
ebc2cda
to
cbe4d43
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With OpenSSLv3, there is a tiny regression in the cert generation. The
issuer entry is modified after the check for self-signed certificate.
So it fails with:
workaround is to use intermediate CSR and generate after the cert based
on this CSR and by providing the associated extension in order to not
lost the SANs.
Signed-off-by: Mathieu Tortuyaux mtortuyaux@microsoft.com
Testing done
dev-libs/openssl: upgrade to v3 flatcar-archive/coreos-overlay#1305More details here: openssl/openssl#16720
Related-to: flatcar-archive/coreos-overlay#1305