Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deneb support for type conversions #496

Closed
wants to merge 1 commit into from

Conversation

avalonche
Copy link
Collaborator

πŸ“ Summary

β›± Motivation and Context

πŸ“š References


βœ… I have run these commands

  • make lint
  • make test-race
  • go mod tidy
  • I have seen and agree to CONTRIBUTING.md

@avalonche avalonche mentioned this pull request Aug 2, 2023
17 tasks
@codecov-commenter
Copy link

Codecov Report

Merging #496 (b4c6f26) into deneb-signature-checks (af69cf5) will increase coverage by 0.22%.
The diff coverage is 3.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@                    Coverage Diff                     @@
##           deneb-signature-checks     #496      +/-   ##
==========================================================
+ Coverage                   33.43%   33.66%   +0.22%     
==========================================================
  Files                          24       24              
  Lines                        4728     4874     +146     
==========================================================
+ Hits                         1581     1641      +60     
- Misses                       2935     3009      +74     
- Partials                      212      224      +12     
Flag Coverage Ξ”
unittests 33.66% <3.00%> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Ξ”
common/types_spec.go 17.16% <0.00%> (-4.07%) ⬇️
common/utils.go 29.77% <0.00%> (+17.18%) ⬆️
datastore/memcached.go 0.00% <0.00%> (ΓΈ)
services/api/service.go 36.22% <0.00%> (+0.36%) ⬆️
services/api/utils.go 18.42% <0.00%> (-14.40%) ⬇️
database/typesconv.go 27.83% <20.00%> (-3.75%) ⬇️
datastore/redis.go 59.00% <66.66%> (ΓΈ)
datastore/datastore.go 17.60% <100.00%> (ΓΈ)

@avalonche avalonche closed this Jan 30, 2024
@jtraglia jtraglia deleted the type-conversions branch April 11, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants