Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deneb signature checking for block contents #495

Closed
wants to merge 1 commit into from

Conversation

avalonche
Copy link
Collaborator

@avalonche avalonche commented Aug 2, 2023

📝 Summary

Adds signature verification to the blobs and tests. Don't have tests for Deneb signatures as it wasn't easy to get test data from devnets (signed block v2 endpoint only returned the signed beacon block but not signed blob sidecars)

⛱ Motivation and Context

📚 References


✅ I have run these commands

  • make lint
  • make test-race
  • go mod tidy
  • I have seen and agree to CONTRIBUTING.md

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (develop@6a991e8). Click here to learn what that means.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             develop     #495   +/-   ##
==========================================
  Coverage           ?   33.43%           
==========================================
  Files              ?       24           
  Lines              ?     4728           
  Branches           ?        0           
==========================================
  Hits               ?     1581           
  Misses             ?     2935           
  Partials           ?      212           
Flag Coverage Δ
unittests 33.43% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@avalonche avalonche mentioned this pull request Aug 2, 2023
17 tasks
@avalonche avalonche closed this Jan 18, 2024
@jtraglia jtraglia deleted the deneb-signature-checks branch April 11, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants