Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove submit block request wrapper #485

Merged
merged 3 commits into from
Jul 26, 2023

Conversation

avalonche
Copy link
Collaborator

@avalonche avalonche commented Jul 20, 2023

πŸ“ Summary

β›± Motivation and Context

πŸ“š References


βœ… I have run these commands

  • make lint
  • make test-race
  • go mod tidy
  • I have seen and agree to CONTRIBUTING.md

@avalonche avalonche force-pushed the remove-submit-block-request-wrapper branch from a4d5c54 to 0b35819 Compare July 20, 2023 18:32
@codecov-commenter
Copy link

codecov-commenter commented Jul 20, 2023

Codecov Report

❗ No coverage uploaded for pull request base (develop@bf14103). Click here to learn what that means.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             develop     #485   +/-   ##
==========================================
  Coverage           ?   32.30%           
==========================================
  Files              ?       24           
  Lines              ?     4517           
  Branches           ?        0           
==========================================
  Hits               ?     1459           
  Misses             ?     2849           
  Partials           ?      209           
Flag Coverage Ξ”
unittests 32.30% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@avalonche avalonche requested a review from metachris July 20, 2023 18:39
@avalonche avalonche force-pushed the remove-submit-block-request-wrapper branch from 06b088e to bbce911 Compare July 21, 2023 03:43
Base automatically changed from remove-signed-beacon-block to develop July 26, 2023 07:00
@avalonche avalonche force-pushed the remove-submit-block-request-wrapper branch from bbce911 to c434a82 Compare July 26, 2023 07:02
@avalonche avalonche force-pushed the remove-submit-block-request-wrapper branch from c434a82 to d9b476b Compare July 26, 2023 07:06
@avalonche avalonche merged commit f923651 into develop Jul 26, 2023
2 checks passed
@avalonche avalonche deleted the remove-submit-block-request-wrapper branch July 26, 2023 07:45
@avalonche avalonche mentioned this pull request Jul 28, 2023
17 tasks
avalonche added a commit that referenced this pull request Aug 1, 2023
* remove submit block request wrapper types

* fix tests

* fix lint
avalonche added a commit that referenced this pull request Aug 2, 2023
* remove submit block request wrapper types

* fix tests

* fix lint
avalonche added a commit that referenced this pull request Aug 2, 2023
* remove submit block request wrapper types

* fix tests

* fix lint
avalonche added a commit that referenced this pull request Aug 15, 2023
* remove submit block request wrapper types

* fix tests

* fix lint
avalonche added a commit that referenced this pull request Sep 29, 2023
* remove submit block request wrapper types

* fix tests

* fix lint
avalonche added a commit that referenced this pull request Oct 31, 2023
* remove submit block request wrapper types

* fix tests

* fix lint
avalonche added a commit that referenced this pull request Jan 4, 2024
* remove submit block request wrapper types

* fix tests

* fix lint
avalonche added a commit that referenced this pull request Jan 19, 2024
* remove submit block request wrapper types

* fix tests

* fix lint
austonst pushed a commit to aestus-relay/mev-boost-relay that referenced this pull request Jan 25, 2024
* remove submit block request wrapper types

* fix tests

* fix lint
avalonche added a commit that referenced this pull request Jan 30, 2024
* Remove bellatrix from wrapper types (#475)

* Remove bellatrix from wrapper types

* remove test logs

* Remove get header wrapper types (#477)

* Remove signed blinded beacon block wrapper (#482)

* remove signed blinded beacon block wrapper type

* linting

* remove signed beacon block wrapper types (#483)

* Remove submit block request wrapper (#485)

* remove submit block request wrapper types

* fix tests

* fix lint

* Upgrade go-boost-utils (#488)

* Upgrade go-boost-utils

* pr comments

* remove commented out code

* Add custom json marshalling for versioned structs (#493)

* Add deneb signature checking for block contents

* Add deneb support for type conversions

* Add redis and database tests to store deneb payloads

* Block submission to v3 validation endpoint

* Update signed block conversions

* Replace some expectCont with expectOk (#509)

* Allow fork epochs to be 0

* Make attestantio import names consistent (#510)

* Make attestantio import names consistent

* Fix linter errors & two comments

* Fix mistake in redis prefix name (#517)

* Fix mistake in redis prefix for deneb

* Fix typo in prefix

* rebase conflicts from main

* update submit block request

* bug fixes

* fix blob sidecar signature

* ssz encode request to publish block

* use v2 publish endpoint by default

* go mod tidy

* update relay to latest builder-specs

* update go mod

* fix lint and tests

* switch to json encoding instead of ssz for block publishing v2

* add blob logging

* address pr comments

* Handle no deneb fork schedule from beacon client (#572)

* backwards compatibility if no deneb schedule

* Update services/api/service.go

Co-authored-by: Chris Hager <chris@linuxuser.at>

---------

Co-authored-by: Chris Hager <chris@linuxuser.at>

* change specific error log to info because it's expected nowadays (#574)

* Add json and ssz marshalling tests (#573)

* add test vectors

* linting

---------

Co-authored-by: Justin Traglia <95511699+jtraglia@users.noreply.github.com>
Co-authored-by: Chris Hager <chris@linuxuser.at>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants