[trivial] Parameterize greedy-buckets price cutoff percent & update bundle profit to coinbase delta #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wazzymandias
requested review from
Ruteri,
avalonche and
dvush
and removed request for
Ruteri and
avalonche
Wazzymandias
changed the title
Wazzymandias
changed the title
avalonche
reviewed
Jul 6, 2023
avalonche
approved these changes
Jul 6, 2023
1 task
avalonche
pushed a commit
that referenced
this pull request
Jul 10, 2023
…undle profit to coinbase delta (#83) * Parameterize greedy-buckets price cutoff percent to support dynamic bucket sizes * Update profit function to use coinbase difference for bundles instead of total eth * Update CLI to use default pirce cutoff percent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
--miner.price_cutoff_percent, used when--miner.algotype=greedy-bucketsto support dynamic bucket sizes for block building algorithm--miner.price_cutoff_percentto0and--miner.algotype=greedy-bucketsis comparable to "total profit" block building algorithm, where all transactions are sorted by effective gas price, and then sorted by max profit.📚 References
CONTRIBUTING.md