Don't check position of optional txs #100
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Bundle atomicity check also checks correct ordering of txs. It does not work for optional txs because they can be included outside of the bundle boundaries as part of the different bundle or even from the mempool.
This pr removes ordering check for optional txs.
Better way would be to detect if optional tx is outside of the bundle and check if its actually from the different bundle or from the mempool. But detecting it in general case is very hard because of all edge cases like bundles with all optional txs that are also part of mempool (in this case any ordering of the txs can be valid).
Alternative for the future development could be for builder to actually mark which tx is part of which bundle and then we could check if clamed arrangement is consistent.
CONTRIBUTING.md