Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't check position of optional txs #100

Merged
merged 2 commits into from
Aug 22, 2023
Merged

Conversation

dvush
Copy link
Contributor

@dvush dvush commented Aug 16, 2023

📝 Summary

Bundle atomicity check also checks correct ordering of txs. It does not work for optional txs because they can be included outside of the bundle boundaries as part of the different bundle or even from the mempool.

This pr removes ordering check for optional txs.

Better way would be to detect if optional tx is outside of the bundle and check if its actually from the different bundle or from the mempool. But detecting it in general case is very hard because of all edge cases like bundles with all optional txs that are also part of mempool (in this case any ordering of the txs can be valid).

Alternative for the future development could be for builder to actually mark which tx is part of which bundle and then we could check if clamed arrangement is consistent.


@Wazzymandias Wazzymandias merged commit a8ab533 into main Aug 22, 2023
3 checks passed
@Wazzymandias Wazzymandias deleted the revertible-txs-bundle-check branch August 22, 2023 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants