Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: bullet getter and setter #64

Merged
merged 10 commits into from
Oct 30, 2023

Conversation

alestiago
Copy link
Collaborator

@alestiago alestiago commented Jul 21, 2022

Description

Removes setBullet and isBullet in favour of setter and getters.

// Before:
body.setBullet(true);
body.isBullet(); // true

// After:
body.isBullet = true;
body.isBullet; // true

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples.

Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Related Issues

@spydon
Copy link
Member

spydon commented Oct 30, 2023

@alestiago should I close the two open PRs until you get back to them?

@alestiago
Copy link
Collaborator Author

alestiago commented Oct 30, 2023

I can get to them, I'll make some time for it between this and next week.

It is ready for a re-review. Once this is merged I will take a look at the other one.

@alestiago alestiago requested a review from spydon October 30, 2023 16:49
@spydon spydon merged commit ee5d4bf into flame-engine:main Oct 30, 2023
3 checks passed
@alestiago alestiago deleted the refactor/bullet-getter-and-setter branch October 31, 2023 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants