feat: Add more lint rules

doc/flame/examples/pubspec.yaml

@@ -8,10 +8,9 @@ environment:
   flutter: ^2.10.0
 
 dependencies:
+  flame: ^1.1.1
   flutter:
     sdk: flutter
-  flame:
-    path: ../../../packages/flame
 
 dev_dependencies:
   flame_lint: ^0.0.1

doc/tutorials/klondike/app/lib/step3/rank.dart

@@ -5,7 +5,10 @@ import 'package:klondike/step3/klondike_game.dart';
 @immutable
 class Rank {
   factory Rank.fromInt(int value) {
-    assert(value >= 1 && value <= 13);
+    assert(
+      value >= 1 && value <= 13,
+      'value is outside of the bounds of what a rank can be',
+    );
     return _singletons[value - 1];
   }
 

doc/tutorials/klondike/app/lib/step3/suit.dart

@@ -5,7 +5,10 @@ import 'package:klondike/step3/klondike_game.dart';
 @immutable
 class Suit {
   factory Suit.fromInt(int index) {
-    assert(index >= 0 && index <= 3);
+    assert(
+      index >= 0 && index <= 3,
+      'index is outside of the bounds of what a suit can be',
+    );
     return _singletons[index];
   }
 

doc/tutorials/klondike/app/pubspec.yaml

@@ -7,10 +7,9 @@ environment:
   sdk: ^2.15.0
 
 dependencies:
+  flame: ^1.1.1
   flutter:
     sdk: flutter
-  flame:
-    path: ../../../../packages/flame
 
 dev_dependencies:
   flame_lint: ^0.0.1

examples/games/padracing/lib/game_over.dart

@@ -1,5 +1,4 @@
 import 'package:flutter/material.dart' hide Image, Gradient;
-
 import 'package:padracing/menu_card.dart';
 import 'package:padracing/padracing_game.dart';
 
@@ -29,8 +28,8 @@ class GameOver extends StatelessWidget {
                 ),
                 const SizedBox(height: 10),
                 ElevatedButton(
-                  child: const Text('Restart'),
                   onPressed: game.reset,
+                  child: const Text('Restart'),
                 ),
               ],
             ),

examples/games/padracing/lib/tire.dart

@@ -164,9 +164,8 @@ class Tire extends BodyComponent<PadRacingGame> {
     if (isTurnableTire && isTurning) {
       final turnPerTimeStep = _turnSpeedPerSecond * dt;
       final angleNow = joint.jointAngle();
-      final angleToTurn = (desiredAngle - angleNow)
-          .clamp(-turnPerTimeStep, turnPerTimeStep)
-          .toDouble();
+      final angleToTurn =
+          (desiredAngle - angleNow).clamp(-turnPerTimeStep, turnPerTimeStep);
       final angle = angleNow + angleToTurn;
       joint.setLimits(angle, angle);
     } else {

examples/games/padracing/pubspec.yaml

@@ -7,17 +7,17 @@ environment:
   sdk: ">=2.16.0 <3.0.0"
 
 dependencies:
-  flutter:
-    sdk: flutter
   flame: ^1.1.1
   flame_forge2d: ^0.11.0
+  flutter:
+    sdk: flutter
   google_fonts: ^2.3.2
   url_launcher: ^6.1.2
 
 dev_dependencies:
+  flame_lint: ^0.0.1
   flutter_test:
     sdk: flutter
-  flame_lint: ^0.0.1
 
 flutter:
   uses-material-design: true

examples/games/trex/pubspec.yaml

@@ -11,7 +11,6 @@ environment:
 
 dependencies:
   flame: ^1.1.1
-  google_fonts: ^2.3.2
   flutter:
     sdk: flutter
 

examples/lib/stories/camera_and_viewport/camera_component_example.dart

@@ -421,7 +421,10 @@ class Ant extends PositionComponent {
       travelDirection = -travelDirection;
     }
     final nextIndex = travelPathNodeIndex + travelDirection;
-    assert(nextIndex >= 0 && nextIndex < travelPath.length);
+    assert(
+      nextIndex >= 0 && nextIndex < travelPath.length,
+      'nextIndex is outside of the bounds of travelPath',
+    );
     final nextPosition = travelPath[nextIndex];
     var nextAngle =
         angle = -(nextPosition - position).angleToSigned(Vector2(0, -1));
@@ -480,7 +483,7 @@ class InsectLeg {
         path = Path(),
         foot = Vector2.zero() {
     final ok = placeFoot(Vector2(x1, y1));
-    assert(ok);
+    assert(ok, 'The foot was not properly placed');
   }
 
   /// Place where the leg is attached to the body

examples/lib/stories/camera_and_viewport/coordinate_systems_example.dart

@@ -213,26 +213,26 @@ class _CoordinateSystemsState extends State<CoordinateSystemsWidget> {
     required bool start,
   }) {
     final add = Container(
+      margin: const EdgeInsets.all(32),
       child: Center(
         child: TextButton(
           child: const Text('+'),
           onPressed: () => setState(() => blocks[index]++),
         ),
       ),
-      margin: const EdgeInsets.all(32),
     );
     return [
       if (start) add,
       for (int i = 1; i <= blocks[index]; i++)
         GestureDetector(
           child: Container(
+            margin: const EdgeInsets.all(32),
             child: Center(
               child: RotatedBox(
                 quarterTurns: rotated ? 1 : 0,
                 child: Text('Block $i'),
               ),
             ),
-            margin: const EdgeInsets.all(32),
           ),
           onTap: () => setState(() => blocks[index]--),
         ),

examples/lib/stories/effects/rotate_effect_example.dart

@@ -119,7 +119,7 @@ class Compass extends PositionComponent {
 
 class CompassArrow extends PositionComponent {
   CompassArrow({required double width, required double radius})
-      : assert(width <= radius),
+      : assert(width <= radius, 'The width is larger than the radius'),
         _radius = radius,
         _width = width,
         super(size: Vector2(width, 2 * radius), anchor: Anchor.center);
@@ -154,7 +154,7 @@ class CompassArrow extends PositionComponent {
 
 class CompassRim extends PositionComponent {
   CompassRim({required double radius, required double width})
-      : assert(radius > width),
+      : assert(radius > width, 'The width is larger than the radius'),
         _radius = radius,
         _width = width,
         super(

examples/lib/stories/experimental/shapes.dart

@@ -47,7 +47,10 @@ class ShapesExample extends FlameGame {
 
 class ShapesComponent extends Component {
   ShapesComponent(this.shapes, List<Color> colors)
-      : assert(shapes.length == colors.length),
+      : assert(
+          shapes.length == colors.length,
+          'The shapes and colors lists have to be of the same length',
+        ),
         paints = colors
             .map(
               (color) => Paint()
@@ -70,7 +73,10 @@ class ShapesComponent extends Component {
 
 class DotsComponent extends Component {
   DotsComponent(this.shapes, this.shapeColors)
-      : assert(shapes.length == shapeColors.length);
+      : assert(
+          shapes.length == shapeColors.length,
+          'The shapes and shapeColors lists have to be of the same length',
+        );
 
   final List<Shape> shapes;
   final List<Color> shapeColors;

examples/lib/stories/widgets/sprite_button_example.dart

@@ -14,7 +14,7 @@ Widget spriteButtonBuilder(DashbookContext ctx) {
       pressedSrcPosition: Vector2(0, 20),
       pressedSrcSize: Vector2(60, 20),
       onPressed: () {
-        print('Pressed');
+        // Do something
       },
       label: const Text(
         'Sprite Button',

examples/pubspec.yaml

@@ -10,17 +10,17 @@ environment:
   flutter: ">=2.10.0"
 
 dependencies:
+  dashbook: 0.1.6
   flame: ^1.1.1
-  flame_svg: ^1.2.0
   flame_forge2d: ^0.11.0
-  dashbook: 0.1.6
-  google_fonts: ^2.3.2
+  flame_svg: ^1.2.0
   flutter:
     sdk: flutter
-  trex_game:
-    path: games/trex
+  google_fonts: ^2.3.2
   padracing:
     path: games/padracing
+  trex_game:
+    path: games/trex
 
 dev_dependencies:
   flame_lint: ^0.0.1

packages/flame/example/pubspec.yaml

@@ -8,13 +8,11 @@ environment:
   flutter: ">=2.10.0"
 
 dependencies:
-  flame:
-    path: ../
+  flame: ^1.1.1
   flutter:
     sdk: flutter
 
 dev_dependencies:
+  flame_lint: ^0.0.1
   flutter_test:
     sdk: flutter
-  flame_lint:
-    path: ../../flame_lint

packages/flame/lib/src/anchor.dart

@@ -97,7 +97,7 @@ class Anchor {
   ///
   /// If you need to convert anchors to serializable data (like JSON),
   /// use the `toString()` and `valueOf` methods.
-  static Anchor valueOf(String name) {
+  factory Anchor.valueOf(String name) {
     if (_valueNames.containsValue(name)) {
       return _valueNames.entries.singleWhere((e) => e.value == name).key;
     } else {

packages/flame/lib/src/components/component_set.dart

@@ -23,7 +23,7 @@ class ComponentSet extends QueryableOrderedSet<Component> {
         );
 
   @Deprecated('Use ComponentSet.new instead; will be removed in 1.3.0')
-  static ComponentSet createDefault() => ComponentSet();
+  ComponentSet.createDefault() : this();
 
   /// Components whose priority changed since the last update.
   ///

packages/flame/lib/src/components/particle_component.dart

@@ -11,6 +11,7 @@ import 'package:flame/src/particles/particle.dart';
 class ParticleComponent extends Component {
   Particle particle;
 
+  @Deprecated('Will be removed after v1.1, use ParticleSystemComponent instead')
   ParticleComponent(this.particle);
 
   /// Returns progress of the child [Particle].

packages/flame/lib/src/game/flame_game.dart

@@ -120,7 +120,7 @@ class FlameGame extends Component with Game {
     var repeat = true;
     while (repeat) {
       // Give chance to other futures to execute first
-      await Future<void>.delayed(const Duration());
+      await Future<void>.delayed(Duration.zero);
       repeat = false;
       descendants(includeSelf: true).forEach(
         (Component child) {

packages/flame/lib/src/geometry/line.dart

@@ -11,12 +11,12 @@ class Line {
 
   const Line(this.a, this.b, this.c);
 
-  static Line fromPoints(Vector2 p1, Vector2 p2) {
-    final a = p2.y - p1.y;
-    final b = p1.x - p2.x;
-    final c = p2.y * p1.x - p1.y * p2.x;
-    return Line(a, b, c);
-  }
+  Line.fromPoints(Vector2 p1, Vector2 p2)
+      : this(
+          p2.y - p1.y,
+          p1.x - p2.x,
+          p2.y * p1.x - p1.y * p2.x,
+        );
 
   /// Returns an empty list if there is no intersection
   /// If the lines are concurrent it returns one point in the list.

packages/flame/lib/src/image_composition.dart

@@ -84,7 +84,7 @@ class ImageComposition {
   /// Compose all the images into a single composition.
   Future<Image> compose() async {
     // Rect used to determine how big the output image will be.
-    var output = const Rect.fromLTWH(0, 0, 0, 0);
+    var output = Rect.zero;
     final recorder = PictureRecorder();
     final canvas = Canvas(recorder);
 

packages/flame/lib/src/widgets/nine_tile_box.dart

@@ -107,8 +107,8 @@ class NineTileBoxWidget extends StatelessWidget {
           destTileSize: destTileSize,
           width: width,
           height: height,
-          child: child,
           padding: padding,
+          child: child,
         );
       },
       errorBuilder: errorBuilder,
@@ -152,8 +152,8 @@ class InternalNineTileBox extends StatelessWidget {
           destTileSize: destTileSize,
         ),
         child: Container(
-          child: child,
           padding: padding,
+          child: child,
         ),
       ),
     );

packages/flame/pubspec.yaml

@@ -8,19 +8,19 @@ environment:
   flutter: ">=2.10.0"
 
 dependencies:
+  collection: ^1.15.0
   flutter:
     sdk: flutter
   meta: ^1.7.0
-  collection: ^1.15.0
   ordered_set: ^5.0.0
   vector_math: ^2.1.1
 
 dev_dependencies:
-  dartdoc: ^4.1.0
-  mocktail: ^0.3.0
   canvas_test: ^0.2.0
-  flame_test: ^1.4.0
+  dartdoc: ^4.1.0
   flame_lint: ^0.0.1
-  test: any
+  flame_test: ^1.4.0
   flutter_test:
     sdk: flutter
+  mocktail: ^0.3.0
+  test: any

packages/flame/test/collisions/collision_callback_benchmark.dart

@@ -61,6 +61,7 @@ void main() {
       }
       final totalTime = DateTime.now().millisecondsSinceEpoch -
           startTime.millisecondsSinceEpoch;
+      // ignore:avoid_print
       print(
         '$totalTime ms\n'
         '${1000 / (totalTime / ticks)} runs per second\n'

packages/flame/test/game/game_widget/game_widget_test.dart

@@ -69,7 +69,7 @@ FlameTester<_MyGame> myGame({required bool open}) {
   return FlameTester(
     _MyGame.new,
     pumpWidget: (gameWidget, tester) async {
-      await tester.pumpWidget(_Wrapper(child: gameWidget, open: open));
+      await tester.pumpWidget(_Wrapper(open: open, child: gameWidget));
     },
   );
 }

packages/flame/test/text/sprite_font_renderer_test.dart

@@ -94,7 +94,7 @@ Future<SpriteFontRenderer> createRenderer({
   const lines = [
     'ABCDEFGHIJKLMNOPQRSTUVWXYZ',
     'abcdefghijklmnopqrstuvwxyz',
-    '0123456789.,:;—_!?@\$%+-=/*',
+    r'0123456789.,:;—_!?@$%+-=/*',
     '#^&()[]{}<>|\\\'"`~←→↑↓ ',
   ];
   return SpriteFontRenderer(

packages/flame_audio/example/pubspec.yaml

@@ -9,16 +9,13 @@ environment:
   sdk: ">=2.16.0 <3.0.0"
 
 dependencies:
-  flame:
-    path: ../../flame
-  flame_audio:
-    path: ../
+  flame: ^1.1.1
+  flame_audio: ^1.0.2
   flutter:
     sdk: flutter
 
 dev_dependencies:
-  flame_lint:
-    path: ../../flame_lint
+  flame_lint: ^0.0.1
 
 flutter:
   assets: