Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adding HasGameRef.mockGameRef #1520

Merged
merged 1 commit into from
Apr 8, 2022
Merged

feat: adding HasGameRef.mockGameRef #1520

merged 1 commit into from
Apr 8, 2022

Conversation

erickzanardo
Copy link
Member

Description

Solves #1513

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples.

Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Related Issues

st-pasha
st-pasha reviewed Apr 8, 2022
View reviewed changes
packages/flame/lib/src/components/mixins/has_game_ref.dart
///
/// This is meant to be used only for testing purposes.
@visibleForTesting
void mockGameRef(T gameRef) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this could be a simple setter?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to keep prefix mock to make a clear statement that this is a mock. it could me a setter, but the name I wouldn't like to change.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, like, the name reinforces the idea that this is for test purposes only? I guess it makes sense then.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, that is my idea.

@st-pasha
Copy link
Contributor

st-pasha commented Apr 8, 2022

Solves #1513

"Solves" is not one of the Github-approved keywords:
https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests#linking-a-pull-request-to-an-issue

@erickzanardo erickzanardo merged commit 4f389f8 into main Apr 8, 2022
@erickzanardo erickzanardo deleted the erick.mock-game-ref branch April 8, 2022 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@st-pasha st-pasha st-pasha left review comments

@spydon spydon spydon approved these changes

@luanpotter luanpotter Awaiting requested review from luanpotter

@renancaraujo renancaraujo Awaiting requested review from renancaraujo

@wolfenrain wolfenrain Awaiting requested review from wolfenrain

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@erickzanardo @st-pasha @spydon