Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Only end collisions where there was a collision #1471

Merged
merged 4 commits into from
Mar 19, 2022
Merged

fix: Only end collisions where there was a collision #1471

merged 4 commits into from
Mar 19, 2022

Conversation

spydon
Copy link
Member

@spydon spydon commented Mar 19, 2022

Description

Fixes a bug where onCollisionEnd was called for components that never intersected.

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples.

Breaking Change

  • No, this is not a breaking change.

Related Issues

Closes: #1459

@spydon spydon mentioned this pull request Mar 19, 2022
Closed
luanpotter
luanpotter approved these changes Mar 19, 2022
View reviewed changes
Copy link
Member

@luanpotter luanpotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spydon spydon merged commit e1e87fc into main Mar 19, 2022
@spydon spydon deleted the spydon.end-collisions-correctly branch March 19, 2022 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luanpotter luanpotter luanpotter approved these changes

@wolfenrain wolfenrain Awaiting requested review from wolfenrain

@erickzanardo erickzanardo Awaiting requested review from erickzanardo

@renancaraujo renancaraujo Awaiting requested review from renancaraujo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[collision_detection v1.1 rc5] onCollisionEnd is called even though onCollisionStart did not called
2 participants
@spydon @luanpotter