fix: Step time in SpriteAnimation must be positive #1387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spydon
requested review from
luanpotter,
erickzanardo,
renancaraujo and
wolfenrain
erickzanardo
approved these changes
Feb 21, 2022
Co-authored-by: Erick <erickzanardoo@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SpriteAnimationclass now ensures that all animation frames have positive durations. If not, theupdate()method would go into an infinite loop.Current constructors in SpriteAnimation converted into factory constructors so that validity checks can all be made in a single place.
Also make sure that non-looping single-frame
SpriteAnimationworks correctly and calls theonCompletecallback after the frame ends.Checklist
fix:,feat:,docs:etc).docsand added dartdoc comments with///.examples.Breaking Change
Related Issues
Closes #1372
Closes #1379