feat: Added transform to Rect
#1360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spydon
reviewed
Feb 7, 2022
st-pasha
reviewed
Feb 7, 2022
spydon
reviewed
Feb 8, 2022
wolfenrain
changed the title
transformRect to Matrix4transform to Rect
erickzanardo
approved these changes
Feb 8, 2022
spydon
reviewed
Feb 8, 2022
luanpotter
reviewed
Feb 9, 2022
| /// Transform Rect using the transformation defined by [matrix]. | ||
| /// | ||
| /// **Note:** Rotation matrices will increase the size of the [Rect] but they | ||
| /// will not rotate it as [Rect] does not have any rotational values. |
There was a problem hiding this comment.
I wonder if it would be best to validate and throw errors for invalid matrixes.
We could (in the future) also have a version that fully works with any matrix and returns a Polygon to represent non-AA rectangles
There was a problem hiding this comment.
I could, but not sure how to validate that on a matrix. So if anyone has any pointers, I am all ears!
luanpotter
reviewed
Feb 9, 2022
| @@ -36,5 +37,14 @@ void main() { | |||
| expect(r2.position.x, r1.left); | |||
| expect(r2.position.y, r1.top); | |||
| }); | |||
|
|
|||
| test('test transform', () { | |||
There was a problem hiding this comment.
should we test the edge cases mentioned on the comments?
luanpotter
approved these changes
Feb 9, 2022
spydon
reviewed
Feb 21, 2022
spydon
approved these changes
Feb 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Noticed there wasn't a method for transform rects. This method is kinda biased as it will transform from "center".
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the
relevant checkboxes (
[x]). This will ensure a smooth and quick review process.fix:,feat:,docs:etc).docsand added dartdoc comments with///.examples.Breaking Change
Does your PR require Flame users to manually update their apps to accommodate your change?
!,e.g.
feat!:,fix!:).Related Issues
Replace this paragraph with a list of issues related to this PR from the issue database.
Indicate which of these issues are resolved or fixed by this PR, i.e. Fixes #xxxx