Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Simplify GameWidgetState.loaderFuture #1232

Merged
merged 3 commits into from
Dec 17, 2021
Merged

refactor: Simplify GameWidgetState.loaderFuture #1232

merged 3 commits into from
Dec 17, 2021

Conversation

st-pasha
Copy link
Contributor

@st-pasha st-pasha commented Dec 16, 2021 •
edited
Loading

Description

The code in loaderFuture can be simplified using async.

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, doc: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples.

Breaking Change

  • No, this is not a breaking change.

luanpotter
luanpotter approved these changes Dec 16, 2021
View reviewed changes
Copy link
Member

@luanpotter luanpotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@spydon spydon merged commit eb30c2e into flame-engine:main Dec 17, 2021
@st-pasha st-pasha deleted the ps/loader-future branch December 17, 2021 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spydon spydon spydon approved these changes

@luanpotter luanpotter luanpotter approved these changes

@renancaraujo renancaraujo Awaiting requested review from renancaraujo

@wolfenrain wolfenrain Awaiting requested review from wolfenrain

@erickzanardo erickzanardo Awaiting requested review from erickzanardo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@st-pasha @spydon @luanpotter