-
-
Notifications
You must be signed in to change notification settings - Fork 905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add RandomEffectController #1203
Conversation
/// [RandomVariable] is an object capable of producing random values with the | ||
/// prescribed distribution function. Each distribution is implemented within | ||
/// its own derived class. | ||
abstract class RandomVariable { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a feeling this could be useful in a general context, not only to random effect controller;
For example, on Gravity I introduced a method similar to Uniform Random Variable
If so, we could move it to its own file and add factory methods to create both private implementations.
Thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably as a follow-up though?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Add
RandomEffectController
-- a controller that makes the duration of some other effect controller random. This could be useful if the user wants to inject some amount of unpredictability into the effect.Checklist
///
) and updated/added examples indoc/examples
.flutter format
and theflutter analyze
does not report any problems.[next]
inCHANGELOG.md
.Draft
status, by clicking on theReady for review
button in this PR.Breaking Change