Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add key parameters to the rest of the components #3170

Merged
merged 4 commits into from
May 27, 2024
Merged

fix: Add key parameters to the rest of the components #3170

merged 4 commits into from
May 27, 2024

Conversation

RutvikPanchal246
Copy link
Contributor

@RutvikPanchal246 RutvikPanchal246 commented May 26, 2024 •
edited by spydon
Loading

Description

Fixes #3169

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

@RutvikPanchal246 RutvikPanchal246 changed the title Fixes #3169 fix: #3169 May 26, 2024
@RutvikPanchal246 RutvikPanchal246 changed the title fix: #3169 fix: Fixes #3169 (CircleComponent doesn't accept key parameter) May 26, 2024
@spydon spydon changed the title fix: Fixes #3169 (CircleComponent doesn't accept key parameter) fix: Add key parameters to the rest of the components May 26, 2024
@spydon
Copy link
Member

spydon commented May 26, 2024

It would be great if you could add super.key to all the effects that are extending Effect too

@RutvikPanchal246
Copy link
Contributor Author

Sure @spydon , I'll do that changes

@RutvikPanchal246
Copy link
Contributor Author

@spydon Request you to close this pull request, Thank you ❤️

spydon
spydon approved these changes May 27, 2024
View reviewed changes
Copy link
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@spydon spydon merged commit 2477ea0 into flame-engine:main May 27, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spydon spydon spydon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CircleComponent doesn't accept key parameter.
2 participants
@RutvikPanchal246 @spydon