fix!: Update IsometricTileMapComponent to have better defined position and size #3142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luanpotter
commented
Apr 28, 2024
| @@ -101,6 +104,11 @@ class IsometricTileMapComponent extends PositionComponent { | |||
| } | |||
| } | |||
|
|
|||
| @override | |||
| void update(double dt) { | |||
| _recomputeSize(); | |||
There was a problem hiding this comment.
since the block matrix is not final, theoretically it could be changed at any time. luckily recomputing the size is quite cheap so I think this should be fine.
luanpotter
force-pushed
the
luan.iso
branch
2 times, most recently
from
dbb7717
to
258fabe
Compare
spydon
reviewed
Apr 28, 2024
packages/flame/lib/src/components/isometric_tile_map_component.dart
Outdated
Show resolved
Hide resolved
packages/flame/lib/src/components/isometric_tile_map_component.dart
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update IsometricTileMapComponent to have better defined position and size.
Before, the isometric component "zero" would be the center of the 0,0 block.
However, that does not play nicely with our component system if you want to know the size (i.e. bounding box) of a component.
This changes so that the 0,0 of the component is the 0,0 of the AABB around the isometric tiles. Then, it also computes the size of the component accordingly.
This also changes the example to allow toggling between half and full size more easily.
In our example, this is what it looks like:
The example still shows how to compute the previous origin (the purple dot) if you want to.
With full size blocks:
I also updated isomash to check if more complex functionality plays well with the new system:
Checklist
docsand added dartdoc comments with///.examplesordocs.Breaking Change?
Migration instructions
This is a minor breaking change as you might need to "reposition" your tile components, essentially remove the "compensation" for its location that you probably did yourself. If you were centering the tile component based on the available methods such as
map.getBlockCenterPosition, then just make sure you are adding themap.positionto that and it should work as before.