Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add completed future for effects #3123

Merged
merged 2 commits into from
Apr 14, 2024
Merged

Conversation

ufrshubham
Copy link
Collaborator

Description

This PR adds a completed future for effects which completes when the effect finishes.

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

NA

Copy link
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing docs, otherwise it looks good!
Maybe we should remove the callback in V2 and just have completers everywhere?

@ufrshubham
Copy link
Collaborator Author

Missing docs, otherwise it looks good!

Added a line about this in the docs now.

Maybe we should remove the callback in V2 and just have completers everywhere?

Maybe it is fine to keep both because there is slight difference between the two. Callbacks can execute multiple times if the event repeats. On the other hand, we set the completers to null once it is triggered.

@spydon spydon merged commit 5e967de into main Apr 14, 2024
8 checks passed
@spydon spydon deleted the devkage/effects-completed-future branch April 14, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants