Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add custom long tap delay #3110

Merged
merged 4 commits into from
Apr 1, 2024
Merged

feat: Add custom long tap delay #3110

merged 4 commits into from
Apr 1, 2024

Conversation

lucasnlm
Copy link
Contributor

@lucasnlm lucasnlm commented Mar 31, 2024 •
edited
Loading

Description

Currently longTapDelay is hardcoded to 300ms.
This is good for most of the games. But same games required custom long press values.
This PR allows it.

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

@lucasnlm lucasnlm mentioned this pull request Mar 31, 2024
Closed
6 tasks
@lucasnlm lucasnlm marked this pull request as ready for review March 31, 2024 01:56
spydon
spydon approved these changes Mar 31, 2024
View reviewed changes
Copy link
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this solution, lgtm!

@spydon spydon enabled auto-merge (squash) April 1, 2024 14:10
@spydon spydon merged commit a95d7df into flame-engine:main Apr 1, 2024
8 checks passed
@lucasnlm lucasnlm deleted the custom_long_tap_delay_v2 branch April 1, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spydon spydon spydon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lucasnlm @spydon