Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Call render properly from nested FlameGames #3106

Merged
merged 2 commits into from
Mar 29, 2024
Merged

fix: Call render properly from nested FlameGames #3106

merged 2 commits into from
Mar 29, 2024

Conversation

spydon
Copy link
Member

@spydon spydon commented Mar 28, 2024

Description

Old typo where renderTree should call render and not itself when the parent isn't null, since otherwise it will cause an infinite recursion.

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • [-] I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • No, this PR is not a breaking change.

Related Issues

@spydon spydon changed the title fix: Call render properly from FlameGame fix: Call render properly from nested FlameGames Mar 28, 2024
@spydon spydon merged commit cb1e370 into main Mar 29, 2024
8 checks passed
@spydon spydon deleted the fix/call-render-correctly branch March 29, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ufrshubham ufrshubham ufrshubham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@spydon @ufrshubham