Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: Removed unused parameters from SpriteWidget #3074

Merged

Conversation

YukiAttano
Copy link
Contributor

Description

The unused fields of "SpriteWidget", "srcPosition" and "srcSize" and their matching parameter in the default constructor has been removed.

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

If SpriteWidget is used, remove the parameter srcPosition and srcSize as they have not been used in the default constructor.
(This does not belong to SpriteWidget.asset())

Related Issues

Closes #3071

@YukiAttano YukiAttano changed the title fix!: removed unused parameters from SpriteWidget fix!: Removed unused parameters from SpriteWidget Mar 8, 2024
Copy link
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@spydon spydon merged commit f49d24c into flame-engine:main Mar 8, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SpriteWidget has unused parameters
2 participants