Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding autoResetTicker option to SpriteAnimationGroupComponent #2899

Conversation

kurtome
Copy link
Contributor

@kurtome kurtome commented Dec 5, 2023

Description

This adds a new option named autoResetTicker to SpriteAnimationGroupComponent. This defaults to false so it is backwards compatible. When true the option makes the component call animationComponent.reset() anytime the current value is changed.

Checklist

  • I have followed the [Contributor Guide] when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

@kurtome kurtome changed the title feat: adding autoResetTicker option to SpriteAnimationGroupComponent feat: Adding autoResetTicker option to SpriteAnimationGroupComponent Dec 5, 2023
Copy link
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, I feel like this is a bug fix at the same time though, so you can default it to true.

@kurtome
Copy link
Contributor Author

kurtome commented Dec 6, 2023

Lgtm, I feel like this is a bug fix at the same time though, so you can default it to true.

👍 done

@spydon spydon merged commit 001c870 into flame-engine:main Dec 6, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants