Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow sequence effect to be extended #2864

Merged
merged 4 commits into from
Nov 23, 2023

Conversation

erickzanardo
Copy link
Member

Description

With previous implementation of the SequenceEffect didn't allowed developers to extend it and create custom sequence effects. This PR slightly refactors the class so it can now be extended.

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

Replace or remove this text.

@erickzanardo erickzanardo requested a review from a team November 23, 2023 12:08
Copy link
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, just one concern

packages/flame/lib/src/effects/sequence_effect.dart Outdated Show resolved Hide resolved
@spydon spydon enabled auto-merge (squash) November 23, 2023 14:56
@spydon spydon merged commit ee11aae into main Nov 23, 2023
8 checks passed
@spydon spydon deleted the erick.sequence-effect-extendable branch November 23, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants