Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Adding children argument to all constructors in the shape components #2862

Merged
merged 1 commit into from
Nov 22, 2023
Merged

feat: Adding children argument to all constructors in the shape components #2862

merged 1 commit into from
Nov 22, 2023

Conversation

erickzanardo
Copy link
Member

Description

Some constructors in the shape components were missing, this PR adds them.

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

Replace or remove this text.

@erickzanardo erickzanardo requested a review from a team November 22, 2023 14:08
@spydon spydon merged commit 082743d into main Nov 22, 2023
8 checks passed
@spydon spydon deleted the erick.children-shape-components branch November 22, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spydon spydon spydon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@erickzanardo @spydon