Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Setting world on FlameGame camera setter #2831

Merged
merged 3 commits into from
Oct 28, 2023

Conversation

kurtome
Copy link
Contributor

@kurtome kurtome commented Oct 28, 2023

Description

Currently setting a new FlameGame.camera can cause camera.world to no long match game.world, which I think it's safe to assume is never desirable.

This PR sets the camera.world to the game's world when setting a new Camera, this matches what happens when a new World is set on the game (world.camera is set automatically).

Checklist

  • I have followed the [Contributor Guide] when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

@kurtome kurtome changed the title fix: setting world on FlameGame camera setter fix: Setting world on FlameGame camera setter Oct 28, 2023
@ufrshubham
Copy link
Collaborator

What if the new camera already points to another world?

@kurtome
Copy link
Contributor Author

kurtome commented Oct 28, 2023

What if the new camera already points to another world?

I'm open to changing this to only set _camera.world if it's currently null

Copy link
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kurtome can you also add a few words about it in the dartdocs? And possibly a tiny test (optional)?

@kurtome
Copy link
Contributor Author

kurtome commented Oct 28, 2023

@spydon I took a crack at the tests, let me know if they are what you had in mind

Copy link
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff! Thanks for adding the tests too

@spydon spydon enabled auto-merge (squash) October 28, 2023 23:18
@spydon spydon merged commit 3a8e246 into flame-engine:main Oct 28, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants