Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Do not scale debug texts with zoom #2818

Merged
merged 3 commits into from
Oct 15, 2023
Merged

Conversation

l1553k
Copy link
Contributor

@l1553k l1553k commented Oct 13, 2023

Description

Right now the debug texts (certain coordinates of components) use 12px size, but zoom: 10 turns that into 120px. This PR fixes that, debug informations are displayed using 12px size font, regardless of zoom.

Checklist

  • I have followed the [Contributor Guide] when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • No, this PR is not a breaking change.

@l1553k l1553k reopened this Oct 13, 2023
@spydon spydon changed the title WIP: fix: Do not scale debug data with zoom fix: Do not scale debug data with zoom Oct 15, 2023
@spydon spydon changed the title fix: Do not scale debug data with zoom fix: Do not scale debug texts with zoom Oct 15, 2023
@spydon spydon enabled auto-merge (squash) October 15, 2023 19:44
@spydon spydon merged commit c2f3f04 into flame-engine:main Oct 15, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants