feat: Add IgnoreEvents mixin to ignore events for the whole subtree
#2811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
erickzanardo
approved these changes
Oct 11, 2023
spydon
force-pushed
the
spydon/ignore-events-mixin
branch
from
39f9c95
to
33faec7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently the event system is quite inefficient when you have a lot of components since it goes through the whole component tree, with this mixin you can avoid traversing down sub trees that you know don't handle any events.
I'll add docs as soon as #2809 is merged to avoid merge conflicts.
Checklist
docsand added dartdoc comments with///.examplesordocs.Breaking Change?
Related Issues
Replaces #2791 as an intermediary work-around.