feat: AssetsBundle can be customized in Images and AssetsCache. #2807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spydon
reviewed
Oct 9, 2023
Co-authored-by: Lukas Klingsbo <me@lukas.fyi>
spydon
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously,
ImagesandAssetsCachewould always try to fetch assets from therootBundle.With this PR, we can have instances of those classes that uses a custom
AssetsBundle. When this gets merged, we could consider refactoring flame_network_assets to use this new feature and allow Flame users to use the same APIto load both local and network assets.
Checklist
docsand added dartdoc comments with///.examplesordocs.Breaking Change?
Related Issues