docs: Remove last broad cSpell bypass regex and fix all violations #2802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luanpotter
commented
Oct 8, 2023
| @@ -58,7 +60,7 @@ title: Slughorn_encounter | |||
| Slughorn: Oh hello, Tom, is there anything I can help you with? | |||
| Tom: Good {time_of_day()}, Professor. | |||
| -> I was curious about the 12 uses of the dragon blood. | |||
| Slughorn: Such an inquisitive mind! You can read about that in the "Most \ | |||
| Slughorn: Such an inquisitive mind! You can read about that in the "Moste \ | |||
There was a problem hiding this comment.
name of the book was wrong here
luanpotter
commented
Oct 8, 2023
| @@ -36,7 +39,7 @@ space after the tag will be removed from the resulting text. If this is undesire | |||
| add an extra space after the markup tag: | |||
|
|
|||
| ```yarn | |||
| Lorem ipsum dolor sit amet, [carramba/] consectetur adipiscing elit. | |||
| Lorem ipsum dolor sit amet, [wave/] consectetur adipiscing elit. | |||
There was a problem hiding this comment.
I used this documentation to understand what these mean and provide more understandable examples
https://docs.yarnspinner.dev/getting-started/writing-in-yarn/markup#self-closing-attributes
I found that the words used before made it quite hard to understand the purpose of tags
luanpotter
force-pushed
the
luan.cspell-6
branch
from
fdf6152
to
2a629a4
Compare
luanpotter
force-pushed
the
luan.cspell-6
branch
from
2a629a4
to
ff45a66
Compare
luanpotter
force-pushed
the
luan.cspell-6
branch
from
6aceefc
to
c01023c
Compare
spydon
approved these changes
Oct 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove last broad cSpell bypass regex and fix all violations
This bypassed all code blocks within markdown files
(I didn't notice this one before because it was just for markdowns; it explains some weirdness I was seeing)
Now the only remaining restriction is about colors, which I like
Also removed all usages of
cSpell:disablein favor of word-specific bypassesChecklist
docsand added dartdoc comments with///.examplesordocs.Breaking Change?