refactor: Avoid nested conditional expressions whenever possible [DCM] #2784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luanpotter
force-pushed
the
luan.avoid-nested-conditional-expressions
branch
2 times, most recently
from
8820897
to
daa1f83
Compare
luanpotter
force-pushed
the
luan.avoid-nested-conditional-expressions
branch
from
daa1f83
to
cbbc44f
Compare
spydon
approved these changes
Oct 2, 2023
| : isString | ||
| ? ExpressionType.string | ||
| : ExpressionType.unknown; | ||
| return switch (this) { |
There was a problem hiding this comment.
I think this new way will be less performant if the getters will be used a lot when going through a deep tree for example, but it's way more readable. I guess it's not worth optimizing for performance here already though!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I was playing around with the rule avoid-nested-conditional-expressions.
While I philosophically agree with the rule, sadly Dart's new switch-as-an-expression, while a much-needed improvement, still pales in comparison to Kotlin's powerful
when, which makes it impossible to convert all cases of nested ternaries into something actually better. In some cases, given the tools that Dart provides, I think nested ternary is the best option.Notwithstanding, I used the rule to catch many cases where the new switch expression can be used to vastly simplify our codebase, making it much more readable.
Checklist
docsand added dartdoc comments with///.examplesordocs.Breaking Change?