fix: Fix TextBoxComponent alignment bug #2781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luanpotter
commented
Sep 30, 2023
| @@ -163,9 +163,10 @@ void main() { | |||
| _FramedTextBox( | |||
| text: 'That shows thee a weak slave; for the weakest goes to the ' | |||
| 'wall.', | |||
| position: Vector2(410, 320), | |||
| position: Vector2(410, 320) + Vector2(380, 270), | |||
There was a problem hiding this comment.
confirmed this would have broken on current main
spydon
approved these changes
Sep 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix
TextBoxComponentalignment bugThe
anchoris the anchor of the text box component itself.It has nothing to do with the alignment of the text within the box.
The position computed for rendering the text on the above lines is assuming
topLeftanchor for the text.Checklist
docsand added dartdoc comments with///.examplesordocs.Breaking Change?
Related Issues