fix(flame): The component.removeFromParent method should use parent.remove internally
#2779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolfenrain
changed the title
component.removeFromParent should use parent.remove i…component.removeFromParent method should use parent.remove internally
wolfenrain
requested review from
spydon,
erickzanardo,
luanpotter and
renancaraujo
spydon
approved these changes
Sep 29, 2023
spydon
deleted the
fix/component-remove-from-parent-should-use-parent-remove
branch
denisgl7
pushed a commit
to denisgl7/flame
that referenced
this pull request
Sep 29, 2023
…t.remove` internally (flame-engine#2779) The removeFromParent wasn't going through the public methods on the parent, so overwriting the remove would not allow you to detect all removing of children.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
removeFromParentwasn't going through the public methods on the parent, so overwriting theremovewould not allow you to detect all removing of children.Checklist
docsand added dartdoc comments with///.examplesordocs.Breaking Change?
Related Issues