fix: Only use pre-set ReadonlySizeProvider for sizing in HudMarginComponent #2611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spydon
changed the title
spydon
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In a project where we wrapped the
JoystickComponentinto it's ownComponentto separate concerns resizing the window (or hot reloading) would throw an exception leading to a red screen.The
HudMarginComponentcurrently expects the parent to be either aFlameGameorReadOnlySizeProvider, which throws an exception when our wrappedJoystickclass is neither.With the help of @spydon, we came to the conclusion that this fix should work and not break other cases.
Checklist
docsand added dartdoc comments with///.examplesordocs.Breaking Change?
Related Issues
No related issue, I can open one if needed.