Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Accept CollisionType in hitbox constructor #2509

Merged
merged 3 commits into from
Apr 18, 2023
Merged

feat: Accept CollisionType in hitbox constructor #2509

merged 3 commits into from
Apr 18, 2023

Conversation

spydon
Copy link
Member

@spydon spydon commented Apr 16, 2023

Description

With this PR we accept the CollisionType directly in the constructor.

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • No, this PR is not a breaking change.

Related Issues

@spydon spydon enabled auto-merge (squash) April 18, 2023 13:53
@spydon spydon merged commit 8992622 into main Apr 18, 2023
@spydon spydon deleted the spydon/collision-type-in-constructor branch April 18, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renancaraujo renancaraujo renancaraujo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spydon @renancaraujo