Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add a canSee method to the CameraComponent #2270

Merged
merged 7 commits into from
Jan 14, 2023

Conversation

wolfenrain
Copy link
Contributor

Description

Adding inView method so developers can more easily check if a given component is visible from a camera point of view.

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

Copy link
Member

@luanpotter luanpotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spydon spydon requested a review from st-pasha January 13, 2023 15:51
@wolfenrain wolfenrain enabled auto-merge (squash) January 13, 2023 19:00
@wolfenrain wolfenrain changed the title feat: Add an inView method to the CameraComponent feat: Add an isInView method to the CameraComponent Jan 13, 2023
@wolfenrain wolfenrain enabled auto-merge (squash) January 13, 2023 19:01
@wolfenrain wolfenrain changed the title feat: Add an isInView method to the CameraComponent feat: Add a sees method to the CameraComponent Jan 13, 2023
@wolfenrain wolfenrain changed the title feat: Add a sees method to the CameraComponent feat: Add a canSee method to the CameraComponent Jan 14, 2023
doc/flame/camera_component.md Outdated Show resolved Hide resolved
@spydon spydon enabled auto-merge (squash) January 14, 2023 15:17
@spydon spydon merged commit 2347c8f into main Jan 14, 2023
@spydon spydon deleted the feat/add-a-in-view-method-to-camera-component branch January 14, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants