-
-
Notifications
You must be signed in to change notification settings - Fork 895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add a canSee
method to the CameraComponent
#2270
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luanpotter
approved these changes
Jan 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
spydon
approved these changes
Jan 13, 2023
st-pasha
approved these changes
Jan 13, 2023
wolfenrain
changed the title
feat: Add an
feat: Add an Jan 13, 2023
inView
method to the CameraComponent
isInView
method to the CameraComponent
wolfenrain
changed the title
feat: Add an
feat: Add a Jan 13, 2023
isInView
method to the CameraComponent
sees
method to the CameraComponent
st-pasha
approved these changes
Jan 13, 2023
spydon
reviewed
Jan 13, 2023
wolfenrain
changed the title
feat: Add a
feat: Add a Jan 14, 2023
sees
method to the CameraComponent
canSee
method to the CameraComponent
spydon
approved these changes
Jan 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding
inView
method so developers can more easily check if a given component is visible from a camera point of view.Checklist
docs
and added dartdoc comments with///
.examples
ordocs
.Breaking Change?
Related Issues