Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added CameraComponent.withFixedResolution() constructor #2176

Merged
merged 7 commits into from
Nov 25, 2022

Conversation

st-pasha
Copy link
Contributor

Description

This PR adds new constructor for CameraComponent which simulates the old-style FixedResolutionViewport.

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Copy link
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why have a constructor for this instead of a real viewport class? Feels inconsistent that some viewports would be set as a CameraComponent constructor and that some set the viewport field.

@spydon spydon requested a review from a team November 22, 2022 08:37
@spydon
Copy link
Member

spydon commented Nov 25, 2022

@st-pasha do you think you'd be able to add a line in the docs about this method before we do the release today, so that we can include this one? :)

@spydon spydon enabled auto-merge (squash) November 25, 2022 11:11
@spydon spydon merged commit e289f11 into main Nov 25, 2022
@spydon spydon deleted the ps.fixed-size-viewport branch November 25, 2022 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants