-
-
Notifications
You must be signed in to change notification settings - Fork 895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added CameraComponent.withFixedResolution() constructor #2176
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why have a constructor for this instead of a real viewport class? Feels inconsistent that some viewports would be set as a CameraComponent
constructor and that some set the viewport field.
@st-pasha do you think you'd be able to add a line in the docs about this method before we do the release today, so that we can include this one? :) |
Description
This PR adds new constructor for
CameraComponent
which simulates the old-styleFixedResolutionViewport
.Checklist
fix:
,feat:
,docs:
etc).docs
and added dartdoc comments with///
.examples
ordocs
.Breaking Change?