feat: Adding callbacks for EffectController (#1926) #1931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spydon
reviewed
Sep 21, 2022
packages/flame/lib/src/effects/controllers/callback_controller.dart
Outdated
Show resolved
Hide resolved
spydon
reviewed
Sep 21, 2022
packages/flame/lib/src/effects/controllers/callback_controller.dart
Outdated
Show resolved
Hide resolved
st-pasha
reviewed
Sep 21, 2022
st-pasha
reviewed
Sep 21, 2022
packages/flame/lib/src/effects/controllers/callback_controller.dart
Outdated
Show resolved
Hide resolved
st-pasha
reviewed
Sep 21, 2022
packages/flame/lib/src/effects/controllers/callback_controller.dart
Outdated
Show resolved
Hide resolved
st-pasha
approved these changes
Sep 23, 2022
spydon
approved these changes
Sep 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds two callback functions to EffectController factory which are invoked before atMaxDuration or atMinDuration runs.
Checklist
fix:,feat:,docs:etc).docsand added dartdoc comments with///.examplesordocs.Breaking Change?
No
Migration instructions
If the PR is breaking, uncomment this header and add instructions for how to migrate from the
currently released version to the new proposed way.
Related Issues
Closes #1926