Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added Rotate3DDecorator #1805

Merged
merged 40 commits into from
Jul 21, 2022
Merged

feat: Added Rotate3DDecorator #1805

merged 40 commits into from
Jul 21, 2022

Conversation

st-pasha
Copy link
Contributor

@st-pasha st-pasha commented Jul 18, 2022

Description

This PR creates a new Decorator for rotating a component in 3D.

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples.

Breaking Change

  • [-] Yes, this is a breaking change.
  • No, this is not a breaking change.

Related Issues

Depends on #1781

st-pasha and others added 30 commits July 2, 2022 15:50
added 20 new colors and the colors are in alphabetical order.
…ult (#1775)

The caches Game.images and Game.assets now coincide with the static caches Flame.images and Flame.assets by default.

This aims to avoid the situation where the same image (asset) may be loaded twice into two separate caches without the user noticing.
After a previous update to padracing I forgot to update the script that turns it into a file that can be put into DartPad.
* chore(release): publish packages

 - flame@1.2.1
 - flame_audio@1.3.0
 - flame_test@1.6.0
 - flame_bloc@1.6.0
 - flame_fire_atlas@1.2.0
 - flame_flare@1.3.0
 - flame_forge2d@0.12.1
 - flame_lint@0.1.1
 - flame_oxygen@0.1.4
 - flame_rive@1.5.0
 - flame_svg@1.4.0
 - flame_tiled@1.6.0

* Update packages/flame/CHANGELOG.md
Adding projection, ìnvert and inverted to the vector extension.
The images path under sponsors has a relative path from the repository, which are being changed to absolute path (starting with https)
@spydon
Copy link
Member

spydon commented Jul 21, 2022

Will these decorators handle the "local point" conversion for input later?

@st-pasha
Copy link
Contributor Author

Will these decorators handle the "local point" conversion for input later?

This would require a new component, perhaps Position3DComponent. The decorators are really just for visual effects.

@spydon spydon merged commit f05194c into main Jul 21, 2022
@spydon spydon deleted the ps.rotate3d branch July 21, 2022 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants