Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix in test: double data_folder #3412

Merged
merged 1 commit into from
Mar 6, 2024
Merged

bugfix in test: double data_folder #3412

merged 1 commit into from
Mar 6, 2024

Conversation

ya0guang
Copy link
Contributor

No description provided.

helpmefindaname
helpmefindaname approved these changes Mar 1, 2024
View reviewed changes
Copy link
Collaborator

@helpmefindaname helpmefindaname left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting behavior of python. Apparently (path / path) is the same as just path, so no change required.
However I find using just path is way cleaner, hence approving this.

Thank you for your contribution.

@alanakbik
Copy link
Collaborator

Thanks for improving this @ya0guang!

@alanakbik alanakbik merged commit 595d94a into flairNLP:master Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@helpmefindaname helpmefindaname helpmefindaname approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ya0guang @alanakbik @helpmefindaname