Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include flair/py.typed and requirements.txt in source distribution #3206

Merged
merged 1 commit into from
Apr 20, 2023

Conversation

dobbersc
Copy link
Collaborator

This PR fixes the following issues by including the flair/py.typed and requirements.txt in the source distribution (sdist):

This is done by including these files in the source distribution (sdist) by adding a MANIFEST.in file. To test that this works, git checkout this branch, and run:

python setup.py sdist

Then untar the flair-0.12.2.tar.gz file. You should see the requirements.txt and py.typed files inside. Confirm that things work by running the following command:

pip install flair-0.12.2.tar.gz

This should install the package and report:

Processing ./flair-0.12.2.tar.gz
  Installing build dependencies ... done
  Getting requirements to build wheel ... done
  Preparing metadata (pyproject.toml) ... done
[...]
Successfully built flair
Installing collected packages: flair
Successfully installed flair-0.12.2

@alanakbik
Copy link
Collaborator

@dobbersc thanks for fixing this!

@alanakbik alanakbik merged commit d6b8ac2 into master Apr 20, 2023
@dobbersc dobbersc deleted the manifest-in branch April 20, 2023 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

requirements.txt missing from PyPI source tarball
2 participants