add exclude labels parameter to trainer.train and minor change in AIDA #2724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@marcelmmm what is this PR about? Can you please add a description to this PR? |
|
@marcelmmm thanks for adding this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the exclude_labels parameter to ModelTrainer.train. The parameter is already contained in the evaluate of nn.model.classifier. Now every time evaluate is called in ModelTrainer.train the exclude_labels parameter is handed over.
Moreover there is a minor change in the NEL_ENGLISH_AIDA corpus. Default, the (possibly outdated) wikipedia names will be used as label names. Before the corpus used the wikipedia ids to get the label names.
One can now work with up-to-date label names and only use existing wikipedia pages by setting the parameter use_ids_and_check_existence to True.