Refactor embedding logic for data points #2609
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring of embedding logic for data points:
embedding_storage_mode
set_embedding()
andto()
from the data point classes (Sentence
,Token
, etc.) to their parentDataPoint
store_embeddings
for small speed upset_embedding()
method no longer transfers embeddings toflair.device
(only when getting this is done now)DocumentPoolEmbeddings
class can now be instantiated only with a single embedding