Update train.py #543
Open
Update train.py #543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
leng-yue
reviewed
Sep 13, 2024
| os.environ.pop("SLURM_NTASKS_PER_NODE", None) | ||
| # Set environment variables | ||
| os.environ["USE_LIBUV"] = "0" | ||
| os.environ["SLURM_NTASKS"] = os.environ.get("SLURM_NTASKS", None) |
There was a problem hiding this comment.
yes if we don’t need to handle SLURM-related environment variables.
There was a problem hiding this comment.
We don't need that, it should work fine in most slurm envs.
|
Also... I don't see there is a need to make all first-letter of comments uppercase... |
leng-yue
previously approved these changes
Sep 13, 2024
| @@ -1,8 +1,6 @@ | |||
| import os | |||
|
|
|||
| os.environ["USE_LIBUV"] = "0" | |||
There was a problem hiding this comment.
libuv should be in front of everything
There was a problem hiding this comment.
Yeah so that environment variable is set before any libraries that might depend on it are imported.
There was a problem hiding this comment.
It should be set before pytorch, so at least before lightning / DDP imported
|
if there will be anything else let me know i will try!👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR is primarily focused on improving code quality and robustness. The improvements include better environment variable handling, enhanced type hinting, more descriptive logging, robust error handling, configuration validation, and improved code readability.
ThankYou,
RAJAT MISHRA.