New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: check out tokio channels #54

Closed

erhant opened this issue Jun 24, 2024 · 1 comment

Assignees

Labels

refactor

Member

erhant commented Jun 24, 2024 •

edited

Loading

We may make use of channels for various reasons:

Use a oneshot channel for cancellation, instead of tokens maybe
More importantly, use channels to sync between threads such as for P2P and Node.

Relevant links:

erhant added the refactor label

erhant changed the title ~~feat: use onehsot channel instead of cloned Cancellation tokens?~~ feat: check out tokio channels

erhant self-assigned this

Member Author

erhant commented Sep 27, 2024

Cancellation works well, closing this.

erhant closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment