Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rfct: Cancellation tokens DRY #4

Open
erhant opened this issue May 2, 2024 · 1 comment
Open

rfct: Cancellation tokens DRY #4

erhant opened this issue May 2, 2024 · 1 comment
Labels
refactor This needs refactoring

Comments

@erhant
Copy link
Member

erhant commented May 2, 2024

Code is repeating itself within the workers folder, mostly with tokio::select! and using cancellations. Is it possible to be more DRY compliant on these parts?
@erhant erhant added the refactor This needs refactoring label May 2, 2024
@erhant erhant changed the title Cancellation tokens DRY rfk: Cancellation tokens DRY May 6, 2024
@erhant erhant changed the title rfk: Cancellation tokens DRY rfct: Cancellation tokens DRY May 6, 2024
@erhant
Copy link
Member Author

erhant commented May 8, 2024 •
edited
Loading

Slight refactors on subscribe method were added in #13 , but keeping the issue open to look for more perf improvements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor This needs refactoring
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@erhant