-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Segment metadata query on tombstone #15
base: master
Are you sure you want to change the base?
Conversation
@@ -120,7 +123,6 @@ public ColumnHolder getColumnHolder(String columnName) | |||
{ | |||
throw new UnsupportedOperationException(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this also return an empty or null column holder?
FACTORY.mergeRunners( | ||
Execs.directExecutor(), | ||
Lists.newArrayList( | ||
toolChest.preMergeQueryDecoration(runner1), | ||
toolChest.preMergeQueryDecoration(runner2) | ||
) | ||
) |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation Note test
QueryRunnerFactory.mergeRunners
.merge(true) | ||
.build(); | ||
|
||
List<SegmentAnalysis> list = myRunner.run(QueryPlus.wrap(query)).toList(); |
Check notice
Code scanning / CodeQL
Unread local variable Note test
} | ||
|
||
@Override | ||
public Map<String, DimensionHandler> getDimensionHandlers() | ||
{ | ||
throw new UnsupportedOperationException(); | ||
return new HashMap<>(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe Collections.emptyMap()
so it doesn't create garbage
@@ -111,7 +114,7 @@ public void close() | |||
@Override | |||
public List<String> getColumnNames() | |||
{ | |||
throw new UnsupportedOperationException(); | |||
return new ArrayList<>(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Collections.emptyList()
@Override | ||
public RowSignature getRowSignature() | ||
{ | ||
return RowSignature.builder().build(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should create a static final empty signature to re-use for all tombstones
This pull request has been marked as stale due to 60 days of inactivity. |
No description provided.