Segment metadata query on tombstone #15
Conversation
findingrish
changed the title
| @@ -120,7 +123,6 @@ public ColumnHolder getColumnHolder(String columnName) | |||
| { | |||
| throw new UnsupportedOperationException(); | |||
There was a problem hiding this comment.
Should this also return an empty or null column holder?
![github-advanced-security[bot]](https://github.com/avatars/in/57789?s=60&v=4){kind=small}
| FACTORY.mergeRunners( | ||
| Execs.directExecutor(), | ||
| Lists.newArrayList( | ||
| toolChest.preMergeQueryDecoration(runner1), | ||
| toolChest.preMergeQueryDecoration(runner2) | ||
| ) | ||
| ) |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation Note test
| .merge(true) | ||
| .build(); | ||
|
|
||
| List<SegmentAnalysis> list = myRunner.run(QueryPlus.wrap(query)).toList(); |
Check notice
Code scanning / CodeQL
Unread local variable Note test
| } | ||
|
|
||
| @Override | ||
| public Map<String, DimensionHandler> getDimensionHandlers() | ||
| { | ||
| throw new UnsupportedOperationException(); | ||
| return new HashMap<>(); |
There was a problem hiding this comment.
maybe Collections.emptyMap() so it doesn't create garbage
| @@ -111,7 +114,7 @@ public void close() | |||
| @Override | |||
| public List<String> getColumnNames() | |||
| { | |||
| throw new UnsupportedOperationException(); | |||
| return new ArrayList<>(); | |||
| @Override | ||
| public RowSignature getRowSignature() | ||
| { | ||
| return RowSignature.builder().build(); |
There was a problem hiding this comment.
should create a static final empty signature to re-use for all tombstones
|
This pull request has been marked as stale due to 60 days of inactivity. |
No description provided.