chore: fix cargo-audit #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bajtos this branch seems to be based on the other feature branch you just created |
yes, it is. we cannot compile the project before we upgrade Deno. I'll clean up the commits after #354 lands. |
Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
bajtos
force-pushed
the
fix-security-audit
branch
from
bccc862
to
ef51454
Compare
|
@juliangruber would you like to review these changes, or should I go ahead and merge the PR? |
juliangruber
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configure
cargo auditto ignore the following two security advisories:ed25519-dalek→ We are not using this cipher AFAIK
→ There is nothing we can do to fix this; we have to wait for Deno & libp2p to solve this.
Tweak GH Action workflow to re-run Security audit for audit config changes too.