Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade Zinnia to v0.13.0 #8

Merged
merged 1 commit into from
Jun 28, 2023
Merged

chore: upgrade Zinnia to v0.13.0 #8

merged 1 commit into from
Jun 28, 2023

Conversation

bajtos
Copy link
Member

@bajtos bajtos commented Jun 28, 2023

@bajtos bajtos requested a review from juliangruber June 28, 2023 14:34
@bajtos
Copy link
Member Author

bajtos commented Jun 28, 2023

There is a catch: now that Zinnia/Lassie retrieval timeouts were increased from 20 seconds to 1 day, our tests take longer to complete - retrieval of large files no longer times out at 20 seconds but needs 60 seconds instead.

❯ zinnia-dev run test.js
Getting retrieval...
{
  retrieval: {
    id: 5184983,
    cid: "bafybeiaiuzkqucmx27yroyo32453np4yx6xlq3vnlbtsvdaunhg66hivym",
    providerAddress: "/dns4/elastic.dag.house/tcp/443/wss/p2p/QmQzqxhK82kAmKvARFZSkUVS6fo9sySaiogAnx5EnZ6ZmC",
    protocol: "bitswap"
  }
}
Fetching ipfs://bafybeiaiuzkqucmx27yroyo32453np4yx6xlq3vnlbtsvdaunhg66hivym?protocols=bitswap&providers=%2Fdns4%2Felastic.dag.house%2Ftcp%2F443%2Fwss%2Fp2p%2FQmQzqxhK82kAmKvARFZSkUVS6fo9sySaiogAnx5EnZ6ZmC...
Failed to fetch ipfs://bafybeiaiuzkqucmx27yroyo32453np4yx6xlq3vnlbtsvdaunhg66hivym?protocols=bitswap&providers=%2Fdns4%2Felastic.dag.house%2Ftcp%2F443%2Fwss%2Fp2p%2FQmQzqxhK82kAmKvARFZSkUVS6fo9sySaiogAnx5EnZ6ZmC
DOMException: The signal has been aborted

I am not sure if we can do anything about that. What's your take, @juliangruber?

@juliangruber
Copy link
Member

If anything this seems like a test issue. Let's land this for now and improve the test if it becomes annoying :)

@juliangruber juliangruber merged commit a651619 into main Jun 28, 2023
@juliangruber juliangruber deleted the upgrade-zinnia branch June 28, 2023 15:02
@juliangruber
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants