-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: bump http-responders from 2.0.2 to 2.1.0 #203
base: main
Are you sure you want to change the base?
Conversation
Bumps [http-responders](https://github.com/juliangruber/http-responders) from 2.0.2 to 2.1.0. - [Release notes](https://github.com/juliangruber/http-responders/releases) - [Commits](juliangruber/http-responders@v2.0.2...v2.1.0) --- updated-dependencies: - dependency-name: http-responders dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
8f2fc91
to
ae419cc
Compare
can you review please, @bajtos? |
A newer version of http-responders exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
const notFound = (res) => { | ||
res.statusCode = 404 | ||
res.end('Not Found') | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before, we set the response body to 'Not Found'.
What happens after the upgrade, when we call status(res, 404)
? Will the status function set the response body to the status message corresponding with the status code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes! This was my motivation for introducing this method :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
export const status = (res, code) => {
res.statusCode = code
res.end(STATUS_CODES[code])
}
Bumps http-responders from 2.0.2 to 2.1.0.
Release notes
Sourced from http-responders's releases.
Commits
108f41b
2.1.0090ba68
addstatus(res, code)
f65e43e
Bump got and np (#23)a00ceb6
Bump braces from 3.0.2 to 3.0.3 (#22)57612a8
Bump word-wrap from 1.2.3 to 1.2.4 (#21)You can trigger a rebase of this PR by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)