test: remove the integration test #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test is evaluating one batch of real measurements. With the upcoming change introducing committees and majorities, a single batch of measurements is not enough to produce committees with the required size. As a result, most measurements are rejected with COMMITTEE_TOO_SMALL evaluation. In a recent test run, the number of accepted measurements dropped from 14,512 to 2,530. We could fix this test by evaluating all batches in one round, but that would extremely slow down this test to the order of minutes. Let's remove this test for now. If we find a need to test evaluation results of real data, then I'd like to rework the `dry-run` CI step to diff the dry-run output against a snapshot. Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test is evaluating one batch of real measurements. With the upcoming change introducing committees and majorities, a single batch of measurements is not enough to produce committees with the required size. As a result, most measurements are rejected with
COMMITTEE_TOO_SMALLevaluation. In a recent test run, the number of accepted measurements dropped from 14,512 to 2,530.We could fix this test by evaluating all batches in one round, but that would extremely slow down this test to the order of minutes.
Let's remove this test for now. If we find a need to test evaluation results of real data, then I'd like to rework the
dry-runCI step to diff the dry-run output against a snapshot.Links: