Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

round-tracker: fix set precision to bigint. #437 #441

Merged
merged 2 commits into from
Oct 18, 2024
Merged

round-tracker: fix set precision to bigint. #437 #441

merged 2 commits into from
Oct 18, 2024

Conversation

juliangruber
Copy link
Member

Follow up for #437

@juliangruber juliangruber mentioned this pull request Oct 18, 2024
Merged
@juliangruber juliangruber merged commit af19783 into main Oct 18, 2024
8 checks passed
@juliangruber juliangruber deleted the fix/round-tracker-precision branch October 18, 2024 07:11
bajtos
bajtos reviewed Oct 18, 2024
View reviewed changes
Copy link
Member

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix LGTM.

I feel it's important to have a test to cover both edge cases (underflow and overflow). Or at the higher level - when we need to significantly increase and decrease the tasks per node calculated for the new round.

@juliangruber juliangruber mentioned this pull request Oct 20, 2024
Open
@juliangruber
Copy link
Member Author

#443

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bajtos bajtos bajtos left review comments

Assignees
No one assigned
Labels
None yet
Projects
Space Meridian
Status: ✅ done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juliangruber @bajtos